Fix destruction order between SurfaceManger and OffscreenCanvasSurfaceImpl

cc/surfaces/surface_factory.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_SURFACES_SURFACE_FACTORY_H_
 #define CC_SURFACES_SURFACE_FACTORY_H_
 
 #include <memory>
 #include <set>
 #include <unordered_map>
@@ skipping 65 matching lines @@
   void UnrefResources(const ReturnedResourceArray& resources);
 
   SurfaceManager* manager() { return manager_; }
 
   // This can be set to false if resources from this SurfaceFactory don't need
   // to have sync points set on them when returned from the Display, for
   // example if the Display shares a context with the creator.
   bool needs_sync_points() const { return needs_sync_points_; }
   void set_needs_sync_points(bool needs) { needs_sync_points_ = needs; }
 
+  // SurfaceFactory's owner can call this when it finds out that SurfaceManager
+  // is no longer alive during destruction.
+  void didDestroySurfaceManager() { manager_ = nullptr; }

[jbauman, 2016/06/23 19:46:57]

This should be called DidDestroySurfaceManager in chromium style.

[xlai (Olivia), 2016/06/23 20:09:28]

Sorry I just landed the patch after being pushed to fix beta-blocker asap. I'll
follow up with a patch (if this one is not reverted) to fix style here and some
other places. 
Actually, I'm thinking probably "did_destroy_surface_manager()" may be better
because according to Google C++ guide it says cheap function like this may use
this style.

+
  private:
   SurfaceManager* manager_;
   SurfaceFactoryClient* client_;
   SurfaceResourceHolder holder_;
 
   bool needs_sync_points_;
 
   using OwningSurfaceMap =
       std::unordered_map<SurfaceId, std::unique_ptr<Surface>, SurfaceIdHash>;
   OwningSurfaceMap surface_map_;
 
   DISALLOW_COPY_AND_ASSIGN(SurfaceFactory);
 };
 
 }  // namespace cc
 
 #endif  // CC_SURFACES_SURFACE_FACTORY_H_