Remove all safesync_url functionality from gclient

Remove all safesync_url functionality from gclient

R=maruel@chromium.org
BUG=109184
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/99a7f805785be9e44f01886fa95ecc162edf2774

[M-A Ruel, 2016-06-22 15:02:31]

lgtm with one change so people are alerted.

https://codereview.chromium.org/2087313002/diff/1/gclient.py
File gclient.py (left):

https://codereview.chromium.org/2087313002/diff/1/gclient.py#oldcode1301
gclient.py:1301: for s in config_dict.get('solutions', []):
if s.get('safesync_url'):
  raise gclient_utils.Error('safesync_url is not supported anymore, please
remove from your .gclient file')

[agable, 2016-06-22 15:18:05]

https://codereview.chromium.org/2087313002/diff/1/gclient.py
File gclient.py (left):

https://codereview.chromium.org/2087313002/diff/1/gclient.py#oldcode1301
gclient.py:1301: for s in config_dict.get('solutions', []):
On 2016/06/22 at 15:02:31, M-A Ruel wrote:
> if s.get('safesync_url'):
>   raise gclient_utils.Error('safesync_url is not supported anymore, please
remove from your .gclient file')

I added both an error (for folks with a value set) and a note/warning (for folks
with just the key pointing at the empty string). Seem appropriate?

[M-A Ruel, 2016-06-22 15:23:31]

https://codereview.chromium.org/2087313002/diff/1/gclient.py
File gclient.py (left):

https://codereview.chromium.org/2087313002/diff/1/gclient.py#oldcode1301
gclient.py:1301: for s in config_dict.get('solutions', []):
On 2016/06/22 15:18:05, agable wrote:
> On 2016/06/22 at 15:02:31, M-A Ruel wrote:
> > if s.get('safesync_url'):
> >   raise gclient_utils.Error('safesync_url is not supported anymore, please
> remove from your .gclient file')
> 
> I added both an error (for folks with a value set) and a note/warning (for
folks
> with just the key pointing at the empty string). Seem appropriate?

I prefer no warning on '', since literally all clients have it set by default,
and removing the key is really just busy work without gain.

[agable, 2016-06-22 15:27:58]

https://codereview.chromium.org/2087313002/diff/1/gclient.py
File gclient.py (left):

https://codereview.chromium.org/2087313002/diff/1/gclient.py#oldcode1301
gclient.py:1301: for s in config_dict.get('solutions', []):
On 2016/06/22 at 15:23:31, M-A Ruel wrote:
> On 2016/06/22 15:18:05, agable wrote:
> > On 2016/06/22 at 15:02:31, M-A Ruel wrote:
> > > if s.get('safesync_url'):
> > >   raise gclient_utils.Error('safesync_url is not supported anymore, please
> > remove from your .gclient file')
> > 
> > I added both an error (for folks with a value set) and a note/warning (for
folks
> > with just the key pointing at the empty string). Seem appropriate?
> 
> I prefer no warning on '', since literally all clients have it set by default,
and removing the key is really just busy work without gain.

Fair enough. I just didn't want to leave that key floating around, but also
didn't want to get into the mess that is automatically rewriting people's
.gclient files.

[agable, 2016-06-24 17:29:51]

The CQ bit was checked by agable@chromium.org

[agable, 2016-06-24 17:29:52]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/2087313002/#ps40001
(title: "Remove warning, just error")

[commit-bot: I haz the power, 2016-06-24 17:29:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 17:36:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 17:36:51]

Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[agable, 2016-06-24 17:49:43]

The CQ bit was checked by agable@chromium.org

[agable, 2016-06-24 17:49:43]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/2087313002/#ps60001
(title: "Fix smoketest")

[commit-bot: I haz the power, 2016-06-24 17:49:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 17:56:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 17:56:17]

Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[agable, 2016-06-24 18:15:52]

The CQ bit was checked by agable@chromium.org

[agable, 2016-06-24 18:15:53]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/2087313002/#ps80001
(title: "Fix smoketest")

[commit-bot: I haz the power, 2016-06-24 18:16:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 18:19:46]

Description was changed from

==========
Remove all safesync_url functionality from gclient

R=maruel@chromium.org
BUG=109184
==========

to

==========
Remove all safesync_url functionality from gclient

R=maruel@chromium.org
BUG=109184

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/99a7f805785be9...
==========

[commit-bot: I haz the power, 2016-06-24 18:19:48]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/99a7f805785be9...