Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2277)

Unified Diff: recipe_modules/gclient/config.py

Issue 2087313002: Remove all safesync_url functionality from gclient (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Fix smoketest Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « recipe_modules/gclient/api.py ('k') | recipe_modules/gclient/example.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_modules/gclient/config.py
diff --git a/recipe_modules/gclient/config.py b/recipe_modules/gclient/config.py
index 32e026b600c40f5bdb9fd62ab1d60abeae166f9c..cb70c13ac6414b06629809f994715ae0234b36d8 100644
--- a/recipe_modules/gclient/config.py
+++ b/recipe_modules/gclient/config.py
@@ -25,7 +25,6 @@ def BaseConfig(USE_MIRROR=True, GIT_MODE=False, CACHE_DIR=None,
managed = Single(bool, empty_val=True, required=False, hidden=False),
custom_deps = Dict(value_type=(basestring, types.NoneType)),
custom_vars = Dict(value_type=basestring),
- safesync_url = Single(basestring, required=False),
revision = Single(
(basestring, gclient_api.RevisionResolver),
@@ -186,24 +185,12 @@ def chromium(c):
@config_ctx(includes=['chromium'])
def chromium_lkcr(c):
- # TODO(phajdan.jr): Add git hashes for LKCR crbug.com/349277.
- if c.GIT_MODE:
- raise BadConf('Git has problems with safesync_url and LKCR, '
- 'crbug.com/349277 crbug.com/109191') # pragma: no cover
s = c.solutions[0]
- s.safesync_url = 'https://build.chromium.org/p/chromium/lkcr-status/lkgr'
- # TODO(hinoka): Once lkcr exists and is a tag, it should just be lkcr
- # rather than origin/lkcr.
s.revision = 'origin/lkcr'
@config_ctx(includes=['chromium'])
def chromium_lkgr(c):
s = c.solutions[0]
- safesync_url = 'https://chromium-status.appspot.com/lkgr'
- if c.GIT_MODE: # pragma: no cover
- safesync_url = 'https://chromium-status.appspot.com/git-lkgr'
- raise BadConf('Git has problems with safesync_url, crbug.com/109191.')
- s.safesync_url = safesync_url
s.revision = 'origin/lkgr'
@config_ctx(includes=['chromium_bare'])
« no previous file with comments | « recipe_modules/gclient/api.py ('k') | recipe_modules/gclient/example.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698