third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js - Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js

Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browser test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-preload-cellular-test.js ('k') | third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h » ('j') | third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js

diff --git a/third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js b/third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js

index efaa164b0623189666756b98673d44213f06bb8d..326ce6413af4a240a15d61ef0baf044006cae0bf 100644

--- a/third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js

+++ b/third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js

@@ -8,12 +8,11 @@ var newDownlinkMax = 2.0;

// Suppress connection messages information from the host.

if (window.internals) {

- internals.setNetworkStateNotifierTestOnly(true);

- internals.setNetworkConnectionInfo(initialType, initialDownlinkMax);

+ internals.setNetworkConnectionInfoOverride(true, initialType, initialDownlinkMax);

// Reset the state of the singleton network state notifier.

window.addEventListener('beforeunload', function() {

- internals.setNetworkStateNotifierTestOnly(false);

+ internals.clearNetworkConnectionInfoOverride();

}, false);

}