third_party/WebKit/LayoutTests/media/video-preload-cellular-test.js - Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-preload-cellular-test.js

Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browser test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/webfont/font-display-intervention.html ('k') | third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js » ('j') | third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-preload-cellular-test.js

diff --git a/third_party/WebKit/LayoutTests/media/video-preload-cellular-test.js b/third_party/WebKit/LayoutTests/media/video-preload-cellular-test.js

index 4c47179b54f69393ddfb8fb679400d919901ea40..a5348f3be18e652104d411af736f97058141a9bb 100644

--- a/third_party/WebKit/LayoutTests/media/video-preload-cellular-test.js

+++ b/third_party/WebKit/LayoutTests/media/video-preload-cellular-test.js

@@ -1,7 +1,6 @@

function cellular_preload_test() {

async_test(function(t) {

- internals.setNetworkStateNotifierTestOnly(true);

- internals.setNetworkConnectionInfo('cellular3g', 2.0);

+ internals.setNetworkConnectionInfoOverride(true, 'cellular3g', 2.0);

var video = document.querySelector('video');

assert_equals(video.preload, 'none')

@@ -10,7 +9,7 @@ function cellular_preload_test() {

video.onsuspend = t.step_func_done();

video.onprogress = t.unreached_func();

t.add_cleanup(function() {

- internals.setNetworkStateNotifierTestOnly(false);

+ internals.clearNetworkConnectionInfoOverride();

});

}