third_party/WebKit/LayoutTests/netinfo/unregister-during-event.html - Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/netinfo/unregister-during-event.html

Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js ('K') | « third_party/WebKit/LayoutTests/netinfo/type-change-no-listener.html ('k') | third_party/WebKit/LayoutTests/netinfo/web-worker.html » ('j') | third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/netinfo/unregister-during-event.html

diff --git a/third_party/WebKit/LayoutTests/netinfo/unregister-during-event.html b/third_party/WebKit/LayoutTests/netinfo/unregister-during-event.html

index 7325f8827ef799baa3e5f50352c90bdbc75eaa07..d5124dd701eec278dc1331a6979c96ed05f0c145 100644

--- a/third_party/WebKit/LayoutTests/netinfo/unregister-during-event.html

+++ b/third_party/WebKit/LayoutTests/netinfo/unregister-during-event.html

@@ -23,11 +23,11 @@ var handler = function(e) {

shouldBe('connection.downlinkMax', 'newDownlinkMax');

connection.removeEventListener('change', handler);

connection.addEventListener('change', otherHandler);

- internals.setNetworkConnectionInfo(initialType, initialDownlinkMax);

+ internals.setNetworkConnectionInfoOverride(isTypeOnline(initialType), initialType, initialDownlinkMax);

};

connection.addEventListener('change', handler);

-internals.setNetworkConnectionInfo(newConnectionType, newDownlinkMax);

+internals.setNetworkConnectionInfoOverride(isTypeOnline(newConnectionType), newConnectionType, newDownlinkMax);

</script>

</body>