third_party/WebKit/LayoutTests/netinfo/type-change-no-listener.html - Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/netinfo/type-change-no-listener.html

Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js ('K') | « third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js ('k') | third_party/WebKit/LayoutTests/netinfo/unregister-during-event.html » ('j') | third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/netinfo/type-change-no-listener.html

diff --git a/third_party/WebKit/LayoutTests/netinfo/type-change-no-listener.html b/third_party/WebKit/LayoutTests/netinfo/type-change-no-listener.html

index 8a6b2aa1a7a05a977b6644531b0bfac0cb5d0075..5f6d2924911fd0af5f6127b4a1d440d477dfa3db 100644

--- a/third_party/WebKit/LayoutTests/netinfo/type-change-no-listener.html

+++ b/third_party/WebKit/LayoutTests/netinfo/type-change-no-listener.html

@@ -7,7 +7,7 @@

description('Tests that the type changes without an active listener');

-internals.setNetworkConnectionInfo(newConnectionType, newDownlinkMax);

+internals.setNetworkConnectionInfoOverride(isTypeOnline(newConnectionType), newConnectionType, newDownlinkMax);

shouldBe('connection.type', 'newConnectionType');

shouldBe('connection.downlinkMax', 'newDownlinkMax');