Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2087043003: customtabs: Don't create an extra child process when one is already there. (Closed)

Created:
4 years, 6 months ago by Benoit L
Modified:
4 years, 6 months ago
Reviewers:
Ted C, Yusuf
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Don't create an extra child process when one is already there. When a CustomTabActivity is created, the normal initialization sequence in AsyncInitializationActivity allocates a new child connection. This asks Android to start a new isolated process. When a spare renderer or a prerender is used, this is useless and wasteful. Even though this mostly does not happen on the main thread, child process binding usually takes >150ms on Android. Removing this overhead saves memory (a few MB of PSS) and CPU time, and should speed up Custom Tabs startup, especially on low-end devices. BUG=607560 Committed: https://crrev.com/e9391e898bef5109a3b41bb2cf79548c62668e4e Cr-Commit-Position: refs/heads/master@{#401609}

Patch Set 1 #

Messages

Total messages: 11 (4 generated)
Benoit L
4 years, 6 months ago (2016-06-22 14:23:13 UTC) #2
Yusuf
lgtm
4 years, 6 months ago (2016-06-23 14:35:15 UTC) #3
Benoit L
Hi tedchoc@, This is a change to prevent us from needlessly creating child processes, and ...
4 years, 6 months ago (2016-06-23 14:39:13 UTC) #5
Ted C
lgtm
4 years, 6 months ago (2016-06-23 14:45:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087043003/1
4 years, 6 months ago (2016-06-23 14:46:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 15:20:43 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 15:22:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9391e898bef5109a3b41bb2cf79548c62668e4e
Cr-Commit-Position: refs/heads/master@{#401609}

Powered by Google App Engine
This is Rietveld 408576698