chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java - Issue 2087043003: customtabs: Don't create an extra child process when one is already there.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java

Issue 2087043003: customtabs: Don't create an extra child process when one is already there. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/init/NativeInitializationController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java

index 2fd288d2ea4191ba499730e6acadba3c744fabe3..30b6da5c8e60fd43717c3dd1205e603c0a78c75c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java

@@ -24,6 +24,7 @@ import android.view.WindowManager;

import org.chromium.base.ApiCompatibilityUtils;

import org.chromium.base.TraceEvent;

+import org.chromium.base.VisibleForTesting;

import org.chromium.base.library_loader.LoaderErrors;

import org.chromium.base.library_loader.ProcessInitException;

import org.chromium.chrome.browser.ChromeApplication;

@@ -106,7 +107,13 @@ public abstract class AsyncInitializationActivity extends AppCompatActivity impl

// Kick off long running IO tasks that can be done in parallel.

mNativeInitializationController = new NativeInitializationController(this, this);

initializeChildProcessCreationParams();

- mNativeInitializationController.startBackgroundTasks();

+ mNativeInitializationController.startBackgroundTasks(shouldAllocateChildConnection());

+ }

+ /** Controls the parameter of {@link NativeInitializationController#startBackgroundTasks()}.*/

+ @VisibleForTesting

+ public boolean shouldAllocateChildConnection() {

+ return true;

}

/**