Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: net/log/net_log.h

Issue 2086763002: Don't use deprecated ListValue::Append(Value*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/log/net_log.h
diff --git a/net/log/net_log.h b/net/log/net_log.h
index 190b794bc152f5e156c35a450ba6e1e9db1ccb8e..aeb845a9a6c19c485af082be015bf2acc208ab16 100644
--- a/net/log/net_log.h
+++ b/net/log/net_log.h
@@ -132,12 +132,11 @@ class NET_EXPORT NetLog {
EventPhase phase() const { return data_->phase; }
// Serializes the specified event to a Value. The Value also includes the
- // current time. Caller takes ownership of returned Value. Takes in a time
- // to allow back-dating entries.
- base::Value* ToValue() const;
+ // current time. Takes in a time to allow back-dating entries.
+ std::unique_ptr<base::Value> ToValue() const;
// Returns the parameters as a Value. Returns NULL if there are no
- // parameters. Caller takes ownership of returned Value.
+ // parameters.
std::unique_ptr<base::Value> ParametersToValue() const;
private:

Powered by Google App Engine
This is Rietveld 408576698