Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: net/log/net_log.cc

Issue 2086763002: Don't use deprecated ListValue::Append(Value*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/log/net_log.cc
diff --git a/net/log/net_log.cc b/net/log/net_log.cc
index 484abec07787353cc0eb1b6de67ad8f32d71e90f..b038519651a229f369f5b64febb9430f1964bcda 100644
--- a/net/log/net_log.cc
+++ b/net/log/net_log.cc
@@ -152,7 +152,7 @@ bool NetLog::Source::FromEventParameters(base::Value* event_params,
return true;
}
-base::Value* NetLog::Entry::ToValue() const {
+std::unique_ptr<base::Value> NetLog::Entry::ToValue() const {
std::unique_ptr<base::DictionaryValue> entry_dict(
new base::DictionaryValue());
@@ -177,7 +177,7 @@ base::Value* NetLog::Entry::ToValue() const {
entry_dict->Set("params", std::move(value));
}
- return entry_dict.release();
+ return std::move(entry_dict);
}
std::unique_ptr<base::Value> NetLog::Entry::ParametersToValue() const {

Powered by Google App Engine
This is Rietveld 408576698