Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2086613004: When invalidating InlineBox ensure its painting layer is setNeedsRepaint (Closed)

Created:
4 years, 6 months ago by Xianzhu
Modified:
4 years, 6 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When invalidating InlineBox ensure its painting layer is setNeedsRepaint This was missed in https://codereview.chromium.org/2051333005/. BUG=621713 Committed: https://crrev.com/00fc2b7dadc1004fbc3cb7f9f820df9a85c05fdf Cr-Commit-Position: refs/heads/master@{#401107}

Patch Set 1 #

Patch Set 2 : When invalidating InlineBox ensure its painting layer is setNeedsRepaint #

Patch Set 3 : - #

Patch Set 4 : When invalidating InlineBox ensure its painting layer is setNeedsRepaint #

Patch Set 5 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LineLayoutItem.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.cpp View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Xianzhu
With the added DCHECK(paintingLayer()->needsRepaint()) (which was missed in https://codereview.chromium.org/2051333005/), the existing tests can cover this.
4 years, 6 months ago (2016-06-21 17:35:12 UTC) #2
Xianzhu
Note that this just has the same performance as before https://codereview.chromium.org/2051333005/ (when slowSetPaintingLayerNeedsRepaintAndInvalidateDisplayItem was invalidateDisplayItem).
4 years, 6 months ago (2016-06-21 17:36:56 UTC) #3
chrishtr
lgtm
4 years, 6 months ago (2016-06-21 20:41:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086613004/80001
4 years, 6 months ago (2016-06-21 20:42:14 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-21 21:10:55 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 21:12:33 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/00fc2b7dadc1004fbc3cb7f9f820df9a85c05fdf
Cr-Commit-Position: refs/heads/master@{#401107}

Powered by Google App Engine
This is Rietveld 408576698