Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineBox.cpp

Issue 2086613004: When invalidating InlineBox ensure its painting layer is setNeedsRepaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: - Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/api/LineLayoutItem.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/line/InlineBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/line/InlineBox.cpp b/third_party/WebKit/Source/core/layout/line/InlineBox.cpp
index cd6c598d2ac489ed7c7d3ea36fe9c134ec283cae..93f11136dbc85c86e8c7c826cc551c684eeab383 100644
--- a/third_party/WebKit/Source/core/layout/line/InlineBox.cpp
+++ b/third_party/WebKit/Source/core/layout/line/InlineBox.cpp
@@ -65,8 +65,9 @@ void InlineBox::destroy()
{
// We do not need to issue invalidations if the page is being destroyed
// since these objects will never be repainted.
+ // TODO(crbug.com/619630): Make this fast.
if (!m_lineLayoutItem.documentBeingDestroyed())
- m_lineLayoutItem.invalidateDisplayItemClient(*this, PaintInvalidationFull);
+ m_lineLayoutItem.slowSetPaintingLayerNeedsRepaintAndInvalidateDisplayItemClient(*this, PaintInvalidationFull);
delete this;
}
@@ -384,7 +385,8 @@ LayoutPoint InlineBox::flipForWritingMode(const LayoutPoint& point) const
void InlineBox::invalidateDisplayItemClientsRecursively()
{
- getLineLayoutItem().invalidateDisplayItemClient(*this, PaintInvalidationFull);
+ // TODO(crbug.com/619630): Make this fast.
+ getLineLayoutItem().slowSetPaintingLayerNeedsRepaintAndInvalidateDisplayItemClient(*this, PaintInvalidationFull);
if (!isInlineFlowBox())
return;
for (InlineBox* child = toInlineFlowBox(this)->firstChild(); child; child = child->nextOnLine())
« no previous file with comments | « third_party/WebKit/Source/core/layout/api/LineLayoutItem.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698