Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2086583004: Common up SVG transform "change detection" (classification) (Closed)

Created:
4 years, 6 months ago by fs
Modified:
4 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Common up SVG transform "change detection" (classification) This moves the transform change classification to a helper class (SVGTransformChangeDetector) and move LayoutSVGContainer::TransformChange along with it, renaming it to SVGTransformChange. BUG=603956 Committed: https://crrev.com/1826b1322e40dcb8038ccfe970206345ee22d2d6 Cr-Commit-Position: refs/heads/master@{#401111}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
fs
While working on a similar mechanism for LayoutSVGRoot (still some wrinkles left to iron out), ...
4 years, 6 months ago (2016-06-21 18:02:10 UTC) #2
pdr.
LGTM
4 years, 6 months ago (2016-06-21 20:24:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086583004/1
4 years, 6 months ago (2016-06-21 21:07:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 21:19:27 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 21:22:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1826b1322e40dcb8038ccfe970206345ee22d2d6
Cr-Commit-Position: refs/heads/master@{#401111}

Powered by Google App Engine
This is Rietveld 408576698