Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp

Issue 2086583004: Common up SVG transform "change detection" (classification) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Rob Buis <buis@kde.org>
4 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
11 * This library is distributed in the hope that it will be useful, 11 * This library is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of 12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14 * Library General Public License for more details. 14 * Library General Public License for more details.
15 * 15 *
16 * You should have received a copy of the GNU Library General Public License 16 * You should have received a copy of the GNU Library General Public License
17 * along with this library; see the file COPYING.LIB. If not, write to 17 * along with this library; see the file COPYING.LIB. If not, write to
18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
19 * Boston, MA 02110-1301, USA. 19 * Boston, MA 02110-1301, USA.
20 */ 20 */
21 21
22 #include "core/layout/svg/LayoutSVGResourceMarker.h" 22 #include "core/layout/svg/LayoutSVGResourceMarker.h"
23 23
24 #include "core/layout/svg/SVGLayoutSupport.h"
24 #include "wtf/TemporaryChange.h" 25 #include "wtf/TemporaryChange.h"
25 26
26 namespace blink { 27 namespace blink {
27 28
28 LayoutSVGResourceMarker::LayoutSVGResourceMarker(SVGMarkerElement* node) 29 LayoutSVGResourceMarker::LayoutSVGResourceMarker(SVGMarkerElement* node)
29 : LayoutSVGResourceContainer(node) 30 : LayoutSVGResourceContainer(node)
30 { 31 {
31 } 32 }
32 33
33 LayoutSVGResourceMarker::~LayoutSVGResourceMarker() 34 LayoutSVGResourceMarker::~LayoutSVGResourceMarker()
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 147
147 SVGMarkerElement* marker = toSVGMarkerElement(element()); 148 SVGMarkerElement* marker = toSVGMarkerElement(element());
148 ASSERT(marker); 149 ASSERT(marker);
149 150
150 SVGLengthContext lengthContext(marker); 151 SVGLengthContext lengthContext(marker);
151 float w = marker->markerWidth()->currentValue()->value(lengthContext); 152 float w = marker->markerWidth()->currentValue()->value(lengthContext);
152 float h = marker->markerHeight()->currentValue()->value(lengthContext); 153 float h = marker->markerHeight()->currentValue()->value(lengthContext);
153 m_viewport = FloatRect(0, 0, w, h); 154 m_viewport = FloatRect(0, 0, w, h);
154 } 155 }
155 156
156 LayoutSVGContainer::TransformChange LayoutSVGResourceMarker::calculateLocalTrans form() 157 SVGTransformChange LayoutSVGResourceMarker::calculateLocalTransform()
157 { 158 {
158 // TODO(fs): Temporarily, needing a layout implies that the local transform 159 // TODO(fs): Temporarily, needing a layout implies that the local transform
159 // has changed. This should be updated to be more precise and factor in the 160 // has changed. This should be updated to be more precise and factor in the
160 // actual (relevant) changes to the computed user-space transform. 161 // actual (relevant) changes to the computed user-space transform.
161 return selfNeedsLayout() ? TransformChange::Full : TransformChange::None; 162 return selfNeedsLayout() ? SVGTransformChange::Full : SVGTransformChange::No ne;
162 } 163 }
163 164
164 } // namespace blink 165 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698