Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2086523002: Reinstate evil hack to suppress permission warnings for searchProvider (Closed)

Created:
4 years, 6 months ago by Marc Treib
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Reinstate evil hack to suppress permission warnings for searchProvider (mostly a revert of https://codereview.chromium.org/1774103002/ ) BUG=619759 Original issue's description: > Cleanup: remove evil hack to suppress permission warnings for searchProvider > > BUG=533086 > > Committed: https://crrev.com/3e7756c7d39828136744fe7dffe1104eb5433843 > Cr-Commit-Position: refs/heads/master@{#379840} Review-Url: https://codereview.chromium.org/2071293002 Cr-Commit-Position: refs/heads/master@{#400436} (cherry picked from commit 0412744604981ba5d11ef68dfa356ed3d509fc21) Committed: https://chromium.googlesource.com/chromium/src/+/476d033744d348352dbe1209ca1f76f0ee05ff12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1 line) Patch
M chrome/common/extensions/permissions/chrome_permission_message_provider.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M extensions/common/permissions/settings_override_permission.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Marc Treib
4 years, 6 months ago (2016-06-20 15:59:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
476d033744d348352dbe1209ca1f76f0ee05ff12.

Powered by Google App Engine
This is Rietveld 408576698