Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2071293002: Reinstate evil hack to suppress permission warnings for searchProvider (Closed)

Created:
4 years, 6 months ago by Marc Treib
Modified:
4 years, 6 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reinstate evil hack to suppress permission warnings for searchProvider (mostly a revert of https://codereview.chromium.org/1774103002/ ) BUG=619759 Original issue's description: > Cleanup: remove evil hack to suppress permission warnings for searchProvider > > BUG=533086 > > Committed: https://crrev.com/3e7756c7d39828136744fe7dffe1104eb5433843 > Cr-Commit-Position: refs/heads/master@{#379840} Committed: https://crrev.com/0412744604981ba5d11ef68dfa356ed3d509fc21 Cr-Commit-Position: refs/heads/master@{#400436}

Patch Set 1 #

Patch Set 2 : update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1 line) Patch
M chrome/common/extensions/permissions/chrome_permission_message_provider.cc View 1 2 chunks +23 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download
M extensions/common/permissions/settings_override_permission.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Marc Treib
Created Revert of Cleanup: remove evil hack to suppress permission warnings for searchProvider
4 years, 6 months ago (2016-06-17 09:31:19 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071293002/90001
4 years, 6 months ago (2016-06-17 10:35:17 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 11:13:02 UTC) #6
Devlin
Possibly the most depressing cl title to ever lg ("Reinstate evil hack" is typically not ...
4 years, 6 months ago (2016-06-17 16:04:14 UTC) #7
Marc Treib
On 2016/06/17 16:04:14, Devlin wrote: > Possibly the most depressing cl title to ever lg ...
4 years, 6 months ago (2016-06-17 16:12:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071293002/90001
4 years, 6 months ago (2016-06-17 16:12:22 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:90001)
4 years, 6 months ago (2016-06-17 16:16:34 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 16:18:14 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0412744604981ba5d11ef68dfa356ed3d509fc21
Cr-Commit-Position: refs/heads/master@{#400436}

Powered by Google App Engine
This is Rietveld 408576698