Remove ChromePrerenderService, keeping only its skeleton behind.

Remove ChromePrerenderService, keeping only its skeleton behind.

ChromePrerenderService is no longer used, superseeded by (and partially
incompatible with) Custom Tabs. Remove the code, leaving only a skeleton
service behind, to prevent clients expecting it from having issues.

BUG=621889
Committed: https://crrev.com/a373e507aca138969f45b92619ab29b6eae73033
Cr-Commit-Position: refs/heads/master@{#401237}

[Benoit L, 2016-06-21 12:45:09]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 12:45:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086483004/1

[Benoit L, 2016-06-21 12:48:13]

Description was changed from

==========
Remove ChromePrerenderService, keeping only its skeleton behind.

ChromePrerenderService is no longer used, and superseeded (and partially
incompatible) with Custom Tabs. Remove the code, leaving only a skeleton
service behind, to prevent clients expecting it from having issues.

BUG=621889
==========

to

==========
Remove ChromePrerenderService, keeping only its skeleton behind.

ChromePrerenderService is no longer used, superseeded by (and partially
incompatible with) Custom Tabs. Remove the code, leaving only a skeleton
service behind, to prevent clients expecting it from having issues.

BUG=621889
==========

[Benoit L, 2016-06-21 12:53:14]

lizeb@chromium.org changed reviewers:
+ yusufo@chromium.org

[Benoit L, 2016-06-21 12:53:15]

Hi yusufo@,

Best code is no code, time to remove the prerender service, wdyt?

[commit-bot: I haz the power, 2016-06-21 13:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 13:03:43]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Yusuf, 2016-06-21 13:12:12]

https://codereview.chromium.org/2086483004/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java
(left):

https://codereview.chromium.org/2086483004/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java:28:
public class ExternalPrerenderRequestTest extends
ChromeActivityTestCaseBase<ChromeActivity> {
Shouldn't we keep this one and remove the test file that is service specific.
This tests ExternalPrerenderHandler on its own which is still used in custom
tabs, right?

[Benoit L, 2016-06-21 13:30:35]

https://codereview.chromium.org/2086483004/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java
(left):

https://codereview.chromium.org/2086483004/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java:28:
public class ExternalPrerenderRequestTest extends
ChromeActivityTestCaseBase<ChromeActivity> {
On 2016/06/21 13:12:12, Yusuf wrote:
> Shouldn't we keep this one and remove the test file that is service specific.
> This tests ExternalPrerenderHandler on its own which is still used in custom
> tabs, right?

Offline discussion: the best course of action is to remove this test, and bring
it back in a better shape (no @UiThread tests, checking for the prerender start
and completion, no sleep).

Filed crbug.com/621919

[Benoit L, 2016-06-21 13:30:45]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 13:31:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086483004/20001

[Yusuf, 2016-06-21 13:35:29]

lgtm

[commit-bot: I haz the power, 2016-06-21 14:28:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 14:28:14]

Dry run: This issue passed the CQ dry run.

[Benoit L, 2016-06-21 14:38:42]

lizeb@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Benoit L, 2016-06-21 14:38:43]

Hi Ted,

Removing dead code. PTAL, thanks.

[Ted C, 2016-06-21 17:08:42]

lgtm

https://codereview.chromium.org/2086483004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/prerender/ChromePrerenderService.java
(right):

https://codereview.chromium.org/2086483004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/prerender/ChromePrerenderService.java:19:
* A bound service that warms up Chrome and performs actions related with
prerendering urls.
maybe update the description to say this is deprecated and only exists to
prevent legacy clients from crashing?

[Benoit L, 2016-06-22 08:21:22]

The CQ bit was checked by lizeb@chromium.org

[Benoit L, 2016-06-22 08:21:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, yusufo@chromium.org
Link to the patchset: https://codereview.chromium.org/2086483004/#ps40001
(title: "Explain why the service is staying.")

[commit-bot: I haz the power, 2016-06-22 08:21:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086483004/40001

[Benoit L, 2016-06-22 08:21:47]

Thanks!

https://codereview.chromium.org/2086483004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/prerender/ChromePrerenderService.java
(right):

https://codereview.chromium.org/2086483004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/prerender/ChromePrerenderService.java:19:
* A bound service that warms up Chrome and performs actions related with
prerendering urls.
On 2016/06/21 17:08:42, Ted C wrote:
> maybe update the description to say this is deprecated and only exists to
> prevent legacy clients from crashing?

Done.

[commit-bot: I haz the power, 2016-06-22 09:16:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-22 09:17:14]

Description was changed from

==========
Remove ChromePrerenderService, keeping only its skeleton behind.

ChromePrerenderService is no longer used, superseeded by (and partially
incompatible with) Custom Tabs. Remove the code, leaving only a skeleton
service behind, to prevent clients expecting it from having issues.

BUG=621889
==========

to

==========
Remove ChromePrerenderService, keeping only its skeleton behind.

ChromePrerenderService is no longer used, superseeded by (and partially
incompatible with) Custom Tabs. Remove the code, leaving only a skeleton
service behind, to prevent clients expecting it from having issues.

BUG=621889

Committed: https://crrev.com/a373e507aca138969f45b92619ab29b6eae73033
Cr-Commit-Position: refs/heads/master@{#401237}
==========

[commit-bot: I haz the power, 2016-06-22 09:17:16]

Patchset 3 (id:??) landed as
https://crrev.com/a373e507aca138969f45b92619ab29b6eae73033
Cr-Commit-Position: refs/heads/master@{#401237}