chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java - Issue 2086483004: Remove ChromePrerenderService, keeping only its skeleton behind.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

Issue 2086483004: Remove ChromePrerenderService, keeping only its skeleton behind. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Explain why the service is staying. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/prerender/ChromePrerenderService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

index 01e9ff142c75b0063ed8f3d0f104853e01c11cd4..c9848c05e57749199470d720baa2a8ea4aeae581 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

@@ -689,10 +689,6 @@ public class CustomTabsConnection {

private boolean prerenderUrl(

CustomTabsSessionToken session, String url, Bundle extras, int uid) {

ThreadUtils.assertOnUiThread();

- // TODO(lizeb): Prerendering through ChromePrerenderService is

- // incompatible with prerendering through this service. Remove this

- // limitation, or remove ChromePrerenderService.

- WarmupManager.getInstance().disallowPrerendering();

// Ignores mayPrerender() for an empty URL, since it cancels an existing prerender.

if (!mayPrerender(session) && !TextUtils.isEmpty(url)) return false;

if (!mWarmupHasBeenCalled.get()) return false;