Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/metrics/timeline.py

Issue 208643007: Add cleanup for measurements that use tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/perf/measurements/smoothness_controller.py ('K') | « tools/perf/measurements/timeline_based_measurement.py ('k') | tools/telemetry/telemetry/page/page_measurement_unittest_base.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/timeline.py
diff --git a/tools/perf/metrics/timeline.py b/tools/perf/metrics/timeline.py
index 9d95455341de578673dd921996d265ee16569694..442dc88227d0e9b90393b53c5beab91d62f23495 100644
--- a/tools/perf/metrics/timeline.py
+++ b/tools/perf/metrics/timeline.py
@@ -61,6 +61,10 @@ class TimelineMetric(Metric):
for combo in itertools.combinations(self._action_ranges, 2):
assert not combo[0].Intersects(combo[1])
+ def CleanUp(self, tab):
+ if tab.browser.is_tracing_running:
+ tab.browser.StopTracing()
+
def AddActionToIncludeInMetric(self, action):
self._actions.append(action)
« tools/perf/measurements/smoothness_controller.py ('K') | « tools/perf/measurements/timeline_based_measurement.py ('k') | tools/telemetry/telemetry/page/page_measurement_unittest_base.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698