tools/perf/measurements/timeline_based_measurement.py - Issue 208643007: Add cleanup for measurements that use tracing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/timeline_based_measurement.py

Issue 208643007: Add cleanup for measurements that use tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/timeline_based_measurement.py

diff --git a/tools/perf/measurements/timeline_based_measurement.py b/tools/perf/measurements/timeline_based_measurement.py

index 4c4f67f917103705eb99b3d9737af1054c8f93dd..cb839016d1ac923fc7e27847ecaac9a941f7db3a 100644

--- a/tools/perf/measurements/timeline_based_measurement.py

+++ b/tools/perf/measurements/timeline_based_measurement.py

@@ -123,3 +123,7 @@ class TimelineBasedMeasurement(page_measurement.PageMeasurement):

renderer_thread = model.GetRendererThreadFromTab(tab)

meta_metrics = _TimelineBasedMetrics(model, renderer_thread)

meta_metrics.AddResults(results)

+ def CleanUpAfterPage(self, page, tab):

+ if tab.browser.is_tracing_running:

+ tab.browser.StopTracing()