Add cleanup for measurements that use tracing

Add cleanup for measurements that use tracing

BUG=348271
1st commit: https://src.chromium.org/viewvc/chrome?view=rev&revision=259808

NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260454

[nednguyen, 2014-03-21 23:48:41]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2014-03-21 23:48:42]

The CQ bit was unchecked by nednguyen@google.com

[ernstm, 2014-03-25 00:00:53]

https://codereview.chromium.org/208643007/diff/1/tools/perf/measurements/smoo...
File tools/perf/measurements/smoothness_controller.py (right):

https://codereview.chromium.org/208643007/diff/1/tools/perf/measurements/smoo...
tools/perf/measurements/smoothness_controller.py:67: def CleanUp(self, tab):
Can you please add:
if tab.browser.platform.IsRawDisplayFrameRateSupported():
  tab.browser.platform.StopRawDisplayFrameRateMeasurement()

That would probably fix crbug.com/355773 (assuming this is meant to be called
from an exception handler and such handler is already in place).

[nednguyen, 2014-03-25 00:07:24]

On 2014/03/25 00:00:53, ernstm wrote:
>
https://codereview.chromium.org/208643007/diff/1/tools/perf/measurements/smoo...
> File tools/perf/measurements/smoothness_controller.py (right):
> 
>
https://codereview.chromium.org/208643007/diff/1/tools/perf/measurements/smoo...
> tools/perf/measurements/smoothness_controller.py:67: def CleanUp(self, tab):
> Can you please add:
> if tab.browser.platform.IsRawDisplayFrameRateSupported():
>   tab.browser.platform.StopRawDisplayFrameRateMeasurement()
> 
> That would probably fix crbug.com/355773 (assuming this is meant to be called
> from an exception handler and such handler is already in place).

Done

[ernstm, 2014-03-25 05:05:06]

LGTM % nit

https://codereview.chromium.org/208643007/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/page/page_measurement_unittest_base.py (right):

https://codereview.chromium.org/208643007/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/page/page_measurement_unittest_base.py:58:
tracing_closed_called = [False]
Please rename this to stop_tracing_called.

[nednguyen, 2014-03-25 15:37:02]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-25 15:37:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/208643007/40001

[commit-bot: I haz the power, 2014-03-25 16:09:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 16:09:29]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[nednguyen, 2014-03-25 16:12:43]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-25 16:14:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/208643007/40001

[commit-bot: I haz the power, 2014-03-25 16:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 16:52:52]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[nduca, 2014-03-26 17:26:54]

lgtm

[nednguyen, 2014-03-26 17:27:55]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-26 17:28:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/208643007/40001

[commit-bot: I haz the power, 2014-03-26 18:54:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 18:54:33]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[nednguyen, 2014-03-26 20:18:47]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-26 20:19:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/208643007/40001

[commit-bot: I haz the power, 2014-03-26 21:35:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 21:35:50]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[nednguyen, 2014-03-27 03:00:54]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2014-03-27 03:00:55]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2014-03-27 03:40:56]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-27 03:42:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/208643007/230001

[commit-bot: I haz the power, 2014-03-27 06:13:40]

Change committed as 259808

[ernstm, 2014-03-28 20:20:49]

On 2014/03/27 06:13:40, I haz the power (commit-bot) wrote:
> Change committed as 259808

Why has the clean-up of RawDisplayFrameRate been removed again from
smoothness_controller::CleanUp (was added in #2)?

[nednguyen, 2014-03-28 20:23:18]

On 2014/03/28 20:20:49, ernstm wrote:
> On 2014/03/27 06:13:40, I haz the power (commit-bot) wrote:
> > Change committed as 259808
> 
> Why has the clean-up of RawDisplayFrameRate been removed again from
> smoothness_controller::CleanUp (was added in #2)?

This must be a rebase problem. Let me added it again.

[nednguyen, 2014-03-28 20:27:21]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-28 20:28:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/208643007/250001

[commit-bot: I haz the power, 2014-03-28 23:54:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 23:54:32]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[ernstm, 2014-03-29 00:29:00]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-03-29 00:31:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/208643007/250001

[commit-bot: I haz the power, 2014-03-29 02:02:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-29 02:02:56]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[nednguyen, 2014-03-29 03:05:45]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-29 03:09:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/208643007/250001

[commit-bot: I haz the power, 2014-03-29 04:37:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-29 04:37:42]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[ernstm, 2014-03-29 05:33:23]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-03-29 05:33:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/208643007/250001

[commit-bot: I haz the power, 2014-03-29 06:53:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-29 06:53:10]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[nednguyen, 2014-03-29 13:52:36]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-29 13:52:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/208643007/250001

[commit-bot: I haz the power, 2014-03-29 15:23:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-29 15:23:49]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[nduca, 2014-03-30 03:01:45]

just notry=true it

[nednguyen, 2014-03-30 03:36:55]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-30 03:37:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/208643007/250001

[commit-bot: I haz the power, 2014-03-30 05:04:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-30 05:04:55]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[nednguyen, 2014-03-30 05:33:25]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-30 05:33:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/208643007/250001

[commit-bot: I haz the power, 2014-03-30 07:09:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-30 07:09:16]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[nednguyen, 2014-03-30 13:31:48]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-30 13:32:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/208643007/250001

[commit-bot: I haz the power, 2014-03-30 17:39:56]

Change committed as 260454