Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Side by Side Diff: tools/perf/measurements/smoothness_controller.py

Issue 208643007: Add cleanup for measurements that use tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add clean-up of RawDisplayFrameRate back Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from metrics import smoothness 5 from metrics import smoothness
6 from metrics import timeline_interaction_record as tir_module 6 from metrics import timeline_interaction_record as tir_module
7 from telemetry.core.timeline.model import TimelineModel 7 from telemetry.core.timeline.model import TimelineModel
8 from telemetry.page import page_measurement 8 from telemetry.page import page_measurement
9 9
10 import telemetry.core.timeline.bounds as timeline_bounds 10 import telemetry.core.timeline.bounds as timeline_bounds
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 renderer_thread, 58 renderer_thread,
59 interaction_record, 59 interaction_record,
60 results) 60 results)
61 if tab.browser.platform.IsRawDisplayFrameRateSupported(): 61 if tab.browser.platform.IsRawDisplayFrameRateSupported():
62 for r in tab.browser.platform.GetRawDisplayFrameRateMeasurements(): 62 for r in tab.browser.platform.GetRawDisplayFrameRateMeasurements():
63 if r.value is None: 63 if r.value is None:
64 raise MissingDisplayFrameRateError(r.name) 64 raise MissingDisplayFrameRateError(r.name)
65 results.Add(r.name, r.unit, r.value) 65 results.Add(r.name, r.unit, r.value)
66 66
67 def CleanUp(self, tab): 67 def CleanUp(self, tab):
68 if tab.browser.platform.IsRawDisplayFrameRateSupported():
69 tab.browser.platform.StopRawDisplayFrameRateMeasurement()
68 if tab.browser.is_tracing_running: 70 if tab.browser.is_tracing_running:
69 tab.browser.StopTracing() 71 tab.browser.StopTracing()
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698