content/browser/web_contents/web_contents_impl.h - Issue 2086423005: Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2086423005: Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DidFinishNavigation is received when RenderFrameHostImpl is destroyed!! Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/interstitial_page_impl_browsertest.cc ('K') | « content/browser/frame_host/interstitial_page_impl_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 4cc0c5bc1e2e1d7013ff2b7530738a287958566f..498dfcdeaff327e08f664185a7307502c7b59057 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -798,7 +798,7 @@ class CONTENT_EXPORT WebContentsImpl

// So |find_request_manager_| can be accessed for testing.

friend class FindRequestManagerTest;

- // So InterstitialPageImpl can access SetIsLoading.

+ // So InterstitialPageImpl can access UpdateTitleForEntry.

friend class InterstitialPageImpl;

Charlie Reis 2016/06/24 22:21:17 I think it's probably safer to make UpdateTitleFor

afakhry 2016/06/27 14:29:18 Done.

// TODO(brettw) TestWebContents shouldn't exist!

« content/browser/frame_host/interstitial_page_impl_browsertest.cc ('K') | « content/browser/frame_host/interstitial_page_impl_browsertest.cc ('k') | no next file » | no next file with comments »