Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle()

content/browser/web_contents/web_contents_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
 
 #include <stdint.h>
 
 #include <functional>
@@ skipping 780 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest,
                            TwoSubframesCreatePopupMenuWidgetsSimultaneously);
   FRIEND_TEST_ALL_PREFIXES(SitePerProcessAccessibilityBrowserTest,
                            CrossSiteIframeAccessibility);
   FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest,
                            JavaScriptDialogsInMainAndSubframes);
 
   // So |find_request_manager_| can be accessed for testing.
   friend class FindRequestManagerTest;
 
-  // So InterstitialPageImpl can access SetIsLoading.
+  // So InterstitialPageImpl can access UpdateTitleForEntry.
   friend class InterstitialPageImpl;

[Charlie Reis, 2016/06/24 22:21:17]

I think it's probably safer to make UpdateTitleForEntry public and remove the
whole friend declaration, especially if we do the other cleanup I suggested.

[afakhry, 2016/06/27 14:29:18]

Done.

 
   // TODO(brettw) TestWebContents shouldn't exist!
   friend class TestWebContents;
 
   class DestructionObserver;
 
   // Represents a WebContents node in a tree of WebContents structure.
   //
   // Two WebContents with separate FrameTrees can be connected by
   // outer/inner relationship using this class. Note that their FrameTrees
@@ skipping 607 matching lines @@
   // Adds/removes a callback called on creation of each new WebContents.
   static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
   static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
 
   DISALLOW_COPY_AND_ASSIGN(FriendZone);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_