chrome/test/base/browser_with_test_window_test.cc - Issue 2086423005: Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/browser_with_test_window_test.cc

Issue 2086423005: Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Improving comment and removing the NOTREACHED. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc ('K') | « chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc ('k') | content/browser/frame_host/interstitial_page_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/base/browser_with_test_window_test.cc

diff --git a/chrome/test/base/browser_with_test_window_test.cc b/chrome/test/base/browser_with_test_window_test.cc

index b2dda01e98cfe9b81ef29c516fd7b2d7ff3ae389..cfb71ad971982b7917b97a9c44c26ce5160ff5e1 100644

--- a/chrome/test/base/browser_with_test_window_test.cc

+++ b/chrome/test/base/browser_with_test_window_test.cc

@@ -183,10 +183,11 @@ void BrowserWithTestWindowTest::NavigateAndCommitActiveTabWithTitle(

Browser* navigating_browser,

const GURL& url,

const base::string16& title) {

- NavigationController* controller = &navigating_browser->tab_strip_model()->

- GetActiveWebContents()->GetController();

+ WebContents* contents =

+ navigating_browser->tab_strip_model()->GetActiveWebContents();

+ NavigationController* controller = &contents->GetController();

NavigateAndCommit(controller, url);

- controller->GetActiveEntry()->SetTitle(title);

+ contents->UpdateTitleForEntry(controller->GetActiveEntry(), title);

}

void BrowserWithTestWindowTest::DestroyBrowserAndProfile() {