chrome/browser/ui/search/search_tab_helper.cc - Issue 2086423005: Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 2086423005: Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Improving comment and removing the NOTREACHED. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc ('K') | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search/search_tab_helper.cc

diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc

index 3ff3225effe808b617a10aaabdf5f0f290800216..cda38cc8194d9087e472082bc50e4d8a6ff6c862 100644

--- a/chrome/browser/ui/search/search_tab_helper.cc

+++ b/chrome/browser/ui/search/search_tab_helper.cc

@@ -291,8 +291,10 @@ void SearchTabHelper::DidStartNavigationToPendingEntry(

// prevents any flickering of the tab title.

content::NavigationEntry* entry =

web_contents_->GetController().GetPendingEntry();

- if (entry)

- entry->SetTitle(l10n_util::GetStringUTF16(IDS_NEW_TAB_TITLE));

+ if (entry) {

+ web_contents_->UpdateTitleForEntry(

+ entry, l10n_util::GetStringUTF16(IDS_NEW_TAB_TITLE));

+ }

}

@@ -320,7 +322,8 @@ void SearchTabHelper::DidNavigateMainFrame(

if (entry && entry->GetTitle().empty() &&

(entry->GetVirtualURL() == GURL(chrome::kChromeUINewTabURL) ||

search::NavEntryIsInstantNTP(web_contents_, entry))) {

- entry->SetTitle(l10n_util::GetStringUTF16(IDS_NEW_TAB_TITLE));

+ web_contents_->UpdateTitleForEntry(

+ entry, l10n_util::GetStringUTF16(IDS_NEW_TAB_TITLE));

}