Fix interstitial pages not updating the task manager renderers' titles and favicons

Fix interstitial pages not updating the task manager renderers' titles and favicons

After we fixed the WebContentsObserver::TitleWasSet() events not being emitted in some cases
including the interstitial pages in this CL: https://codereview.chromium.org/2086423005/,
we now make sure that the favicon is also updated when the title changes.
We also use the DidFinishNavigation() instead of DidNavigateMainFrame().

Screen recording: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LX0VtUnNWaEd6cUU/view?usp=sharing

BUG=607074
Committed: https://crrev.com/707a8b14b3a547d21668166d062d57a9c55767ba
Cr-Commit-Position: refs/heads/master@{#405519}

[Charlie Reis, 2016-07-13 22:22:56]

creis@chromium.org changed reviewers:
+ creis@chromium.org, nick@chromium.org

[Charlie Reis, 2016-07-13 22:22:56]

LGTM once https://codereview.chromium.org/2086423005/, though you'll need an
owner to review as well.  (Adding Nick.)

Is there a way to test for regression?

[afakhry, 2016-07-14 15:16:50]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 15:17:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2016-07-14 15:18:44]

On 2016/07/13 22:22:56, Charlie Reis wrote:
> LGTM once https://codereview.chromium.org/2086423005/, though you'll need an
> owner to review as well.  (Adding Nick.)
> 
> Is there a way to test for regression?

For regressions in Interstitial page titles, the browser tests we expanded in
the preceding CL should cover us well I think.

[commit-bot: I haz the power, 2016-07-14 16:23:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 16:23:23]

Dry run: This issue passed the CQ dry run.

[ncarter (slow), 2016-07-14 17:43:44]

lgtm

[afakhry, 2016-07-14 17:48:43]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2016-07-14 17:48:43]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2148083002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-14 17:49:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 18:21:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-14 18:21:43]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 18:24:15]

Description was changed from

==========
Fix interstitial pages not updating the task manager renderers' titles and
favicons

After we fixed the WebContentsObserver::TitleWasSet() events not being emitted
in some cases
including the interstitial pages in this CL:
https://codereview.chromium.org/2086423005/,
we now make sure that the favicon is also updated when the title changes.
We also use the DidFinishNavigation() instead of DidNavigateMainFrame().

Screen recording:
https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LX0VtUnNWaEd6cUU/vie...

BUG=607074
==========

to

==========
Fix interstitial pages not updating the task manager renderers' titles and
favicons

After we fixed the WebContentsObserver::TitleWasSet() events not being emitted
in some cases
including the interstitial pages in this CL:
https://codereview.chromium.org/2086423005/,
we now make sure that the favicon is also updated when the title changes.
We also use the DidFinishNavigation() instead of DidNavigateMainFrame().

Screen recording:
https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LX0VtUnNWaEd6cUU/vie...

BUG=607074

Committed: https://crrev.com/707a8b14b3a547d21668166d062d57a9c55767ba
Cr-Commit-Position: refs/heads/master@{#405519}
==========

[commit-bot: I haz the power, 2016-07-14 18:24:15]

Patchset 2 (id:??) landed as
https://crrev.com/707a8b14b3a547d21668166d062d57a9c55767ba
Cr-Commit-Position: refs/heads/master@{#405519}