content/public/browser/web_contents.h - Issue 2086423005: Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle()

Unified Diff: content/public/browser/web_contents.h

Issue 2086423005: Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle() Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/navigation_entry.h ('K') | « content/public/browser/navigation_entry.h ('k') | extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/web_contents.h

diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h

index 36996f00cdc50c5c21055e96450d1200cdca1bf1..82705e82641c45147bf5126e45330fb8d29dcdb7 100644

--- a/content/public/browser/web_contents.h

+++ b/content/public/browser/web_contents.h

@@ -317,6 +317,13 @@ class WebContents : public PageNavigator,

// download, in which case the URL would revert to what it was previously).

virtual const base::string16& GetTitle() const = 0;

+ // Saves the given title to the navigation entry and does associated work. It

+ // will update history and the view for the new title, and also synthesize

Lei Zhang 2016/07/13 23:17:17 "with the new title" ?

afakhry 2016/07/13 23:36:17 Done.

+ // titles for file URLs that have none (so we require that the URL of the

Lei Zhang 2016/07/13 23:17:17 I don't quite understand the part in the parenthes

afakhry 2016/07/13 23:36:17 Probably! I just copied this comment from: https:/

Lei Zhang 2016/07/13 23:44:24 Sounds like a good time to fix both. I think it sh

afakhry 2016/07/14 00:01:53 Done.

+ // entry already be set).

+ virtual void UpdateTitleForEntry(NavigationEntry* entry,

+ const base::string16& title) = 0;

// The max page ID for any page that the current SiteInstance has loaded in

// this WebContents. Page IDs are specific to a given SiteInstance and

// WebContents, corresponding to a specific RenderView in the renderer.