Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle()

content/public/browser/web_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 
 #include <stdint.h>
 
 #include <set>
@@ skipping 299 matching lines @@
 
   virtual const PageImportanceSignals& GetPageImportanceSignals() const = 0;
 
   // Tab navigation state ------------------------------------------------------
 
   // Returns the current navigation properties, which if a navigation is
   // pending may be provisional (e.g., the navigation could result in a
   // download, in which case the URL would revert to what it was previously).
   virtual const base::string16& GetTitle() const = 0;
 
+  // Saves the given title to the navigation entry and does associated work. It
+  // will update history and the view for the new title, and also synthesize

[Lei Zhang, 2016/07/13 23:17:17]

"with the new title" ?

[afakhry, 2016/07/13 23:36:17]

Done.

+  // titles for file URLs that have none (so we require that the URL of the

[Lei Zhang, 2016/07/13 23:17:17]

I don't quite understand the part in the parenthesis. Does "we" refer to
WebContents?

[afakhry, 2016/07/13 23:36:17]

Probably! I just copied this comment from:
https://cs.chromium.org/chromium/src/content/browser/web_contents/web_content...
when I moved it to the base WebContents.

[Lei Zhang, 2016/07/13 23:44:24]

Sounds like a good time to fix both. I think it should say:

Thus |entry| must have a URL set.

[afakhry, 2016/07/14 00:01:53]

Done.

+  // entry already be set).
+  virtual void UpdateTitleForEntry(NavigationEntry* entry,
+                                   const base::string16& title) = 0;
+
   // The max page ID for any page that the current SiteInstance has loaded in
   // this WebContents.  Page IDs are specific to a given SiteInstance and
   // WebContents, corresponding to a specific RenderView in the renderer.
   // Page IDs increase with each new page that is loaded by a tab.
   virtual int32_t GetMaxPageID() = 0;
 
   // The max page ID for any page that the given SiteInstance has loaded in
   // this WebContents.
   virtual int32_t GetMaxPageIDForSiteInstance(SiteInstance* site_instance) = 0;
 
@@ skipping 419 matching lines @@
 
  private:
   // This interface should only be implemented inside content.
   friend class WebContentsImpl;
   WebContents() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_