Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle()

content/public/browser/navigation_entry.h

Index: content/public/browser/navigation_entry.h
diff --git a/content/public/browser/navigation_entry.h b/content/public/browser/navigation_entry.h
index 92f020f9448166c6eb75d7c68032b4f3acd39280..91fc211f0eaafb0b14874daf36e81abc4111a531 100644
--- a/content/public/browser/navigation_entry.h
+++ b/content/public/browser/navigation_entry.h
@@ -87,6 +87,8 @@ class NavigationEntry {
   // The caller is responsible for detecting when there is no title and
   // displaying the appropriate "Untitled" label if this is being displayed to
   // the user.
+  // Use WebContents::UpdateTitleForEntry() in most cases. Only call the below

[Charlie Reis, 2016/07/13 22:21:47]

Let's elaborate a bit:

Use WebContents::UpdateTitleForEntry() in most cases, since that notifies
observers when the visible title changes.  Only call SetTitle directly if this
entry is known to not be visible.

[afakhry, 2016/07/13 22:52:50]

Done.

+  // NavigationEntry::SetTitle() when it's known to be a non-visible entry.
   virtual void SetTitle(const base::string16& title) = 0;
   virtual const base::string16& GetTitle() const = 0;