Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle()

content/public/browser/navigation_entry.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_
 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 69 matching lines @@
   //
   // GetVirtualURL() will return the URL to display to the user in all cases, so
   // if there is no overridden display URL, it will return the actual one.
   virtual void SetVirtualURL(const GURL& url) = 0;
   virtual const GURL& GetVirtualURL() const = 0;
 
   // The title as set by the page. This will be empty if there is no title set.
   // The caller is responsible for detecting when there is no title and
   // displaying the appropriate "Untitled" label if this is being displayed to
   // the user.
+  // Use WebContents::UpdateTitleForEntry() in most cases. Only call the below

[Charlie Reis, 2016/07/13 22:21:47]

Let's elaborate a bit:

Use WebContents::UpdateTitleForEntry() in most cases, since that notifies
observers when the visible title changes.  Only call SetTitle directly if this
entry is known to not be visible.

[afakhry, 2016/07/13 22:52:50]

Done.

+  // NavigationEntry::SetTitle() when it's known to be a non-visible entry.
   virtual void SetTitle(const base::string16& title) = 0;
   virtual const base::string16& GetTitle() const = 0;
 
   // Page state is an opaque blob created by Blink that represents the state of
   // the page. This includes form entries and scroll position for each frame.
   // We store it so that we can supply it back to Blink to restore form state
   // properly when the user goes back and forward.
   //
   // NOTE: This state is saved to disk and used to restore previous states.  If
   // the format is modified in the future, we should still be able to deal with
@@ skipping 119 matching lines @@
   virtual void SetRedirectChain(const std::vector<GURL>& redirects) = 0;
   virtual const std::vector<GURL>& GetRedirectChain() const = 0;
 
   // True if this entry is restored and hasn't been loaded.
   virtual bool IsRestored() const = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_