Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle()

chrome/browser/devtools/devtools_ui_bindings.cc

Index: chrome/browser/devtools/devtools_ui_bindings.cc
diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc
index e083cfbf8aa6f592c6766830864c135922a40f1e..c38e7625a5d32534b53c897fab39be5b40cc77a6 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.cc
+++ b/chrome/browser/devtools/devtools_ui_bindings.cc
@@ -536,9 +536,8 @@ void DevToolsUIBindings::InspectedURLChanged(const std::string& url) {
   content::NavigationController& controller = web_contents()->GetController();
   content::NavigationEntry* entry = controller.GetActiveEntry();
   // DevTools UI is not localized.

[ncarter (slow), 2016/07/13 18:56:02]

question for charlie: can we/should we need to do anything to discourage clients
from calling SetTitle on the NavigationEntry directly? Can we hide that method
from content/public?

[Charlie Reis, 2016/07/13 21:02:23]

I think we need to keep it for cases that use it before giving the entry to a
WebContents, like ContentSerializedNavigationBuilder::ToNavigationEntry.

That said, can you add something to the NavigationEntry::SetTitle comment
telling people to use UpdateTitleForEntry in most cases, and only call SetTitle
directly if it's known to be a non-visible entry?

[afakhry, 2016/07/13 22:10:27]

Done, added the comment.

-  entry->SetTitle(
-      base::UTF8ToUTF16(base::StringPrintf(kTitleFormat, url.c_str())));
-  web_contents()->NotifyNavigationStateChanged(content::INVALIDATE_TYPE_TITLE);
+  web_contents()->UpdateTitleForEntry(
+      entry, base::UTF8ToUTF16(base::StringPrintf(kTitleFormat, url.c_str())));
 }
 
 void DevToolsUIBindings::LoadNetworkResource(const DispatchCallback& callback,