Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle()

chrome/browser/devtools/devtools_ui_bindings.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/devtools_ui_bindings.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 517 matching lines @@
   callback.Run(nullptr);
 }
 
 void DevToolsUIBindings::InspectElementCompleted() {
   delegate_->InspectElementCompleted();
 }
 
 void DevToolsUIBindings::InspectedURLChanged(const std::string& url) {
   content::NavigationController& controller = web_contents()->GetController();
   content::NavigationEntry* entry = controller.GetActiveEntry();
   // DevTools UI is not localized.

[ncarter (slow), 2016/07/13 18:56:02]

question for charlie: can we/should we need to do anything to discourage clients
from calling SetTitle on the NavigationEntry directly? Can we hide that method
from content/public?

[Charlie Reis, 2016/07/13 21:02:23]

I think we need to keep it for cases that use it before giving the entry to a
WebContents, like ContentSerializedNavigationBuilder::ToNavigationEntry.

That said, can you add something to the NavigationEntry::SetTitle comment
telling people to use UpdateTitleForEntry in most cases, and only call SetTitle
directly if it's known to be a non-visible entry?

[afakhry, 2016/07/13 22:10:27]

Done, added the comment.

-  entry->SetTitle(
-      base::UTF8ToUTF16(base::StringPrintf(kTitleFormat, url.c_str())));
-  web_contents()->NotifyNavigationStateChanged(content::INVALIDATE_TYPE_TITLE);
+  web_contents()->UpdateTitleForEntry(
+      entry, base::UTF8ToUTF16(base::StringPrintf(kTitleFormat, url.c_str())));
 }
 
 void DevToolsUIBindings::LoadNetworkResource(const DispatchCallback& callback,
                                              const std::string& url,
                                              const std::string& headers,
                                              int stream_id) {
   GURL gurl(url);
   if (!gurl.is_valid()) {
     base::DictionaryValue response;
     response.SetInteger("statusCode", 404);
@@ skipping 549 matching lines @@
 void DevToolsUIBindings::FrontendLoaded() {
   if (frontend_loaded_)
     return;
   frontend_loaded_ = true;
 
   // Call delegate first - it seeds importants bit of information.
   delegate_->OnLoadCompleted();
 
   AddDevToolsExtensionsToClient();
 }