Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: src/IceTargetLoweringMIPS32.cpp

Issue 2086423002: Subzero, MIPS32: UnimplementedError removed from most common crashers (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringMIPS32.cpp
diff --git a/src/IceTargetLoweringMIPS32.cpp b/src/IceTargetLoweringMIPS32.cpp
index f17b02d757b4a4eea4f5ddafffca3938f7106f2a..430820eff63985477dc81ebe22995bec2e2c45fe 100644
--- a/src/IceTargetLoweringMIPS32.cpp
+++ b/src/IceTargetLoweringMIPS32.cpp
@@ -480,14 +480,12 @@ void TargetMIPS32::emitVariable(const Variable *Var) const {
const Type FrameSPTy = IceType_i32;
if (Var->hasReg()) {
Str << '$' << getRegName(Var->getRegNum(), Var->getType());
- return;
} else {
int32_t Offset = Var->getStackOffset();
Str << Offset;
Jim Stichnoth 2016/06/22 15:53:56 The only issue here that I can think of is if Offs
Str << "($" << getRegName(getFrameOrStackReg(), FrameSPTy);
Str << ")";
}
- UnimplementedError(getFlags());
}
TargetMIPS32::CallingConv::CallingConv()
@@ -2123,13 +2121,11 @@ void TargetDataMIPS32::lowerGlobals(const VariableDeclarationList &Vars,
void TargetDataMIPS32::lowerConstants() {
if (getFlags().getDisableTranslation())
return;
- UnimplementedError(getFlags());
}
void TargetDataMIPS32::lowerJumpTables() {
if (getFlags().getDisableTranslation())
return;
- UnimplementedError(getFlags());
}
// Helper for legalize() to emit the right code to lower an operand to a
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698