Subzero, MIPS32: UnimplementedError removed from most common crashers

Subzero, MIPS32: UnimplementedError removed from most common crashers

UnimplementedError is removed from three functions because it causes
crashes in almost every test from tests_lit/llvm2ice_tests.

emitVariable appears as correct, UnimplementedError may be there by mistake.

lowerConstants is unimplemented, but its obvious without UnimeplementedError.

lowerJumpTables is unimplemented, but its obvious without UnimeplementedError.

We comment these three anyway while changing and testing, so removing them will
not affect final results anyway.

R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=2e08a06fc552f02e70f473510e192ce378c3bffe

[obucinac, 2016-06-22 14:48:28]

Description was changed from

==========
Subzero, MIPS32: UnimplementedError removed from most common crashers

UnimplementedError is removed from three functions because it causes
crashes in almost every test from tests_lit/llvm2ice_tests.

emitVariable appears as correct, UnimplementedError may be there by mistake.

lowerConstants is unimplemented, but its obvious without UnimeplementedError.

lowerJumpTables is unimplemented, but its obvious without UnimeplementedError.

We comment these three anyway while changing and testing, so removing them will
not affect final results anyway.
==========

to

==========
Subzero, MIPS32: UnimplementedError removed from most common crashers

UnimplementedError is removed from three functions because it causes
crashes in almost every test from tests_lit/llvm2ice_tests.

emitVariable appears as correct, UnimplementedError may be there by mistake.

lowerConstants is unimplemented, but its obvious without UnimeplementedError.

lowerJumpTables is unimplemented, but its obvious without UnimeplementedError.

We comment these three anyway while changing and testing, so removing them will
not affect final results anyway.
==========

[obucinac, 2016-06-22 14:48:28]

obucinac@gmail.com changed reviewers:
+ mohit.bhakkad@imgtec.com, sagar.thakur@imgtec.com, stichnot@chromium.org

[Jim Stichnoth, 2016-06-22 15:53:57]

lgtm

https://codereview.chromium.org/2086423002/diff/1/src/IceTargetLoweringMIPS32...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/2086423002/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:485: Str << Offset;
The only issue here that I can think of is if Offset is too large to be encoded
in this address mode.  But that will surely get tested elsewhere, so it seems OK
now.

[Jim Stichnoth, 2016-06-22 15:57:05]

Description was changed from

==========
Subzero, MIPS32: UnimplementedError removed from most common crashers

UnimplementedError is removed from three functions because it causes
crashes in almost every test from tests_lit/llvm2ice_tests.

emitVariable appears as correct, UnimplementedError may be there by mistake.

lowerConstants is unimplemented, but its obvious without UnimeplementedError.

lowerJumpTables is unimplemented, but its obvious without UnimeplementedError.

We comment these three anyway while changing and testing, so removing them will
not affect final results anyway.
==========

to

==========
Subzero, MIPS32: UnimplementedError removed from most common crashers

UnimplementedError is removed from three functions because it causes
crashes in almost every test from tests_lit/llvm2ice_tests.

emitVariable appears as correct, UnimplementedError may be there by mistake.

lowerConstants is unimplemented, but its obvious without UnimeplementedError.

lowerJumpTables is unimplemented, but its obvious without UnimeplementedError.

We comment these three anyway while changing and testing, so removing them will
not affect final results anyway.

R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-06-22 15:57:07]

Committed patchset #1 (id:1) manually as
2e08a06fc552f02e70f473510e192ce378c3bffe (presubmit successful).