Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2086403002: Remove the Kasko based out of process browser hang instrumentation. (Closed)

Created:
4 years, 6 months ago by manzagop (departed)
Modified:
3 years, 3 months ago
CC:
chromium-reviews, scottmg, Sébastien Marchand
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the Kasko based out of process browser hang instrumentation. This CL removes the out-of-process browser hang instrumentation used to capture 20s hangs and failed rendezvous crash reports in one-off canary releases. The Kasko reporter is deprecated, and CrashPad does not yet support the use case. The plan is to restore this functionality once CrashPad supports it. BUG=622314 Committed: https://crrev.com/32d4643f0c60110d73c0ce8e01d0f88aa95bd8b0 Cr-Commit-Position: refs/heads/master@{#402189}

Patch Set 1 #

Patch Set 2 : Missing gyp change #

Patch Set 3 : Fix a comment #

Patch Set 4 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -720 lines) Patch
M build/common.gypi View 1 2 3 3 chunks +1 line, -22 lines 0 comments Download
M chrome/browser/BUILD.gn View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/process_singleton_win.cc View 4 chunks +1 line, -80 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/chrome_watcher/BUILD.gn View 2 chunks +29 lines, -36 lines 0 comments Download
M chrome/chrome_watcher/chrome_watcher.gypi View 1 chunk +52 lines, -70 lines 0 comments Download
M chrome/chrome_watcher/chrome_watcher_main.cc View 4 chunks +2 lines, -44 lines 0 comments Download
D chrome/chrome_watcher/kasko_util.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/chrome_watcher/kasko_util.cc View 1 chunk +0 lines, -399 lines 0 comments Download
M third_party/kasko/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/kasko/kasko.gni View 1 2 3 1 chunk +1 line, -12 lines 0 comments Download
M third_party/kasko/kasko.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
manzagop (departed)
Hey Patrick, Could you have a look? Thanks, Pierre
4 years, 6 months ago (2016-06-22 14:57:07 UTC) #3
Patrick Monette
lgtm
4 years, 6 months ago (2016-06-22 21:48:17 UTC) #4
manzagop (departed)
Hi jochen@, I'm looking for OWNERS' review for the first 4 files (pmonette@ is part ...
4 years, 6 months ago (2016-06-23 18:57:58 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-24 13:35:10 UTC) #7
manzagop (departed)
Thanks for the review!
4 years, 5 months ago (2016-06-27 14:23:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2086403002/40001
4 years, 5 months ago (2016-06-27 14:23:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/250676)
4 years, 5 months ago (2016-06-27 14:25:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2086403002/60001
4 years, 5 months ago (2016-06-27 15:03:35 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-27 15:52:17 UTC) #18
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/32d4643f0c60110d73c0ce8e01d0f88aa95bd8b0 Cr-Commit-Position: refs/heads/master@{#402189}
4 years, 5 months ago (2016-06-27 15:53:54 UTC) #20
grt (UTC plus 2)
base/win/wait_chain* appears to be unused since this CL landed. can it be removed as well, ...
3 years, 3 months ago (2017-09-15 08:14:32 UTC) #22
manzagop (departed)
3 years, 3 months ago (2017-09-15 14:05:49 UTC) #23
Message was sent while issue was closed.
On 2017/09/15 08:14:32, grt (UTC plus 2) wrote:
> base/win/wait_chain* appears to be unused since this CL landed. can it be
> removed as well, or is it being used in some other project somehow?

Yes, it can be removed. Patrick can chime in if I'm wrong.

Powered by Google App Engine
This is Rietveld 408576698