Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: build/common.gypi

Issue 2086403002: Remove the Kasko based out of process browser hang instrumentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 934c137826be02c7218ef8bcb46e630731ef37cc..924d3c00051a46f09267fc5f696b60fb4d5e3388 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1036,19 +1036,6 @@
# http://crbug.com/574476
'fastbuild%': 2,
}],
- # Enable hang report capture. Capture can only be enabled for 32bit
- # Windows.
- ['OS=="win" and target_arch=="ia32" and branding=="Chrome"', {
- # Enable hang reports from the watcher process.
- 'kasko_hang_reports%': 0,
- # Enable failed rendez-vous reports.
- 'kasko_failed_rdv_reports%': 0,
- }, {
- # Enable hang reports from the watcher process.
- 'kasko_hang_reports%': 0,
- # Enable failed rendez-vous reports.
- 'kasko_failed_rdv_reports%': 0,
- }],
],
# Kasko reporting is disabled by default, but may get enabled below.
@@ -1203,8 +1190,6 @@
'use_sanitizer_options%': '<(use_sanitizer_options)',
'syzyasan%': '<(syzyasan)',
'kasko%': '<(kasko)',
- 'kasko_hang_reports%': '<(kasko_hang_reports)',
- 'kasko_failed_rdv_reports%': '<(kasko_failed_rdv_reports)',
'syzygy_optimize%': '<(syzygy_optimize)',
'lsan%': '<(lsan)',
'msan%': '<(msan)',
@@ -2014,14 +1999,8 @@
}, {
'win_console_app%': 0,
}],
- # Disable hang reporting for syzyasan builds.
+ # Enable the Kasko reporter for syzyasan builds.
['syzyasan==1', {
- # Note: override.
- 'kasko_hang_reports': 0,
- 'kasko_failed_rdv_reports': 0,
- }],
- # Enable the Kasko reporter for syzyasan builds and hang reporting.
- ['syzyasan==1 or kasko_hang_reports==1 or kasko_failed_rdv_reports==1', {
'kasko': 1,
}],
['component=="shared_library"', {
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698