Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(16)

Issue 2086393003: Make callers of FromUTC(Local)Exploded in base/ use new time API. (Closed)

Created:
3 years, 3 months ago by maksims (do not use this acc)
Modified:
3 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, asvitkine+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make callers of FromUTC(Local)Exploded in base/ use new time API. Use new time conversion API in accordance with https://codereview.chromium.org/1988663002/ BUG=601900 Committed: https://crrev.com/c9e6026a6a3ec5016f382953c408c9aa1a1bb0d5 Cr-Commit-Position: refs/heads/master@{#402730}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M base/i18n/time_formatting_unittest.cc View 5 chunks +10 lines, -5 lines 0 comments Download
M base/metrics/field_trial.cc View 1 chunk +7 lines, -1 line 0 comments Download
M base/test/test_reg_util_win_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/time/time_unittest.cc View 6 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2086393003/1
3 years, 3 months ago (2016-06-28 09:52:14 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 3 months ago (2016-06-28 10:49:51 UTC) #7
maksims (do not use this acc)
please review
3 years, 3 months ago (2016-06-28 10:51:08 UTC) #8
Mark Mentovai
LGTM
3 years, 3 months ago (2016-06-28 13:34:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2086393003/1
3 years, 3 months ago (2016-06-29 05:05:38 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 3 months ago (2016-06-29 05:13:13 UTC) #13
commit-bot: I haz the power
3 years, 3 months ago (2016-06-29 05:14:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9e6026a6a3ec5016f382953c408c9aa1a1bb0d5
Cr-Commit-Position: refs/heads/master@{#402730}

Powered by Google App Engine
This is Rietveld 408576698