base/test/test_reg_util_win_unittest.cc - Issue 2086393003: Make callers of FromUTC(Local)Exploded in base/ use new time API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/test_reg_util_win_unittest.cc

Issue 2086393003: Make callers of FromUTC(Local)Exploded in base/ use new time API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/test/test_reg_util_win_unittest.cc

diff --git a/base/test/test_reg_util_win_unittest.cc b/base/test/test_reg_util_win_unittest.cc

index 299acbb0a09f52271547b3a4363dee7a7a6db185..9534fef4c4e94e6dd769b534a5f390ef5a8dfe57 100644

--- a/base/test/test_reg_util_win_unittest.cc

+++ b/base/test/test_reg_util_win_unittest.cc

@@ -101,7 +101,8 @@ TEST_F(RegistryOverrideManagerTest, Basic) {

TEST_F(RegistryOverrideManagerTest, DeleteStaleKeys) {

base::Time::Exploded kTestTimeExploded = {2013, 11, 1, 4, 0, 0, 0, 0};

- base::Time kTestTime = base::Time::FromUTCExploded(kTestTimeExploded);

+ base::Time kTestTime;

+ EXPECT_TRUE(base::Time::FromUTCExploded(kTestTimeExploded, &kTestTime));

base::string16 path_garbage = fake_test_key_root_ + L"\\Blah";

base::string16 path_very_stale =

« no previous file with comments | « base/metrics/field_trial.cc ('k') | base/time/time_unittest.cc » ('j') | no next file with comments »