Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2086363005: Revert of Make DesktopWindowTreeHostX11::ShouldWindowContentsBeTransparent() relies on argb visual flag (Closed)

Created:
4 years, 6 months ago by blundell
Modified:
4 years, 6 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make DesktopWindowTreeHostX11::ShouldWindowContentsBeTransparent() relies on argb visual flag (patchset #30 id:580001 of https://codereview.chromium.org/1998653002/ ) Reason for revert: The unittests added in widget_unittest.cc fail on Win10. See the report with failure output here: https://chromium-swarm.appspot.com/user/task/2f9a5518a647e510 (scroll down to see the output of running the tests) Original issue's description: > Make DesktopWindowTreeHostX11::ShouldWindowContentsBeTransparent() relies on argb visual flag > > If depth is 32 and if there is a compositing manager then transparency is supported. > > Do not force transparency if Widget::InitParams::TRANSLUCENT_WINDOW is set whereas transparency is not supported. > Which is the same behavior as on OS_WIN. > > Also add a new test WidgetTest.Transparency_DesktopWidget to widget_unittest.cc which ensures that transparency state of the native window matches what returns ShouldWindowContentsBeTransparent(). > > BUG=589509 > > R=erg@chromium.org, mgiuca@chromium.org, sadrul@chromium.org > > TEST=views_unittests --gtest_filter=*WidgetTest.Transparency* > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/29d8c51452a83dcbc359679e8ce36af41af64e36 > Cr-Commit-Position: refs/heads/master@{#401826} TBR=sadrul@chromium.org,jbauman@chromium.org,piman@chromium.org,sky@chromium.org,erg@chromium.org,mgiuca@chromium.org,j.isorce@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=589509 Committed: https://crrev.com/b6287c064906f9a2139c4be8499befe5cc572e5d Cr-Commit-Position: refs/heads/master@{#401835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -96 lines) Patch
M ui/views/test/widget_test.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/test/widget_test_aura.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/test/widget_test_mac.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 4 chunks +0 lines, -77 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
blundell
4 years, 6 months ago (2016-06-24 08:50:13 UTC) #2
Created Revert of Make
DesktopWindowTreeHostX11::ShouldWindowContentsBeTransparent() relies on argb
visual flag

Powered by Google App Engine
This is Rietveld 408576698