Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2086353003: Reland of write scopes of non-simple default arguments (Closed)

Created:
4 years, 6 months ago by Dan Ehrenberg
Modified:
4 years, 6 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of write scopes of non-simple default arguments (patchset #1 id:1 of https://codereview.chromium.org/2081323006/ ) Reason for revert: Infra issue appears to be over TBR=adamk@chromium.org Original issue's description: > Revert of Rewrite scopes of non-simple default arguments (patchset #5 id:80001 of https://codereview.chromium.org/2077283004/ ) > > Reason for revert: > Seems to close tree (but it could be an infra issue) > > Original issue's description: > > Rewrite scopes of non-simple default arguments > > > > Default parameters have additional declaration block scopes inserted > > around them when something in the function scope calls eval. This > > patch sets the parent scope of the expressions introduced due to > > those defaults to the new block scope. > > > > R=adamk > > BUG=chromium:616386 > > > > Committed: https://crrev.com/0e14baf712955a1993f742647bb2adc293702b80 > > Cr-Commit-Position: refs/heads/master@{#37198} > > TBR=adamk@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:616386 > > Committed: https://crrev.com/dd50262933d2ac087da32be887a7c18385fd998e > Cr-Commit-Position: refs/heads/master@{#37201} TBR=adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:616386 Committed: https://crrev.com/2601900dda887f5dc5c1849be68934de9295b908 Cr-Commit-Position: refs/heads/master@{#37202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M src/parsing/parameter-initializer-rewriter.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 1 chunk +21 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-616386.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dan Ehrenberg
Created Reland of write scopes of non-simple default arguments
4 years, 6 months ago (2016-06-22 21:07:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086353003/1
4 years, 6 months ago (2016-06-22 21:07:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 21:08:03 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 21:10:15 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2601900dda887f5dc5c1849be68934de9295b908
Cr-Commit-Position: refs/heads/master@{#37202}

Powered by Google App Engine
This is Rietveld 408576698