WebRTC: Remove get_version step from WebRTC bots.

WebRTC: Remove get_version step from WebRTC bots.

WebRTC's Android bots are using the same toolchain as Android
for test execution on Android. Recent changes made the chromium_android
recipe module depend on the chrome/VERSION file in the checkout, which
doesn't exist. Workaround this by providing a way to skip the version
check and apply it to WebRTC's Android testers.

BUG=622606
Committed: https://chromium.googlesource.com/chromium/tools/build/+/79755916f19d34ea45919ae4b791d95368a51f34

[kjellander_chromium, 2016-06-23 07:47:58]

Description was changed from

==========
WebRTC: Remove get_version step from WebRTC bots.

WebRTC's Android bots are using the same toolchain as Android
for test execution on Android. Recent changes made the chromium_android
recipe module depend on the chrome/VERSION file in the checkout, which
doesn't exist. Workaround this by providing a way to skip the version
check and apply it to WebRTC's Android testers.

BUG=622606
TBR=jbudorick@chromium.org
==========

to

==========
WebRTC: Remove get_version step from WebRTC bots.

WebRTC's Android bots are using the same toolchain as Android
for test execution on Android. Recent changes made the chromium_android
recipe module depend on the chrome/VERSION file in the checkout, which
doesn't exist. Workaround this by providing a way to skip the version
check and apply it to WebRTC's Android testers.

BUG=622606
==========

[kjellander_chromium, 2016-06-23 07:48:12]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 07:48:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086333004/1

[jbudorick, 2016-06-23 07:50:25]

lgtm

https://codereview.chromium.org/2086333004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/webrtc/api.py (right):

https://codereview.chromium.org/2086333004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/webrtc/api.py:186:
self.m.chromium_android.shutdown_device_monitor()
Fine with this to fix the bots, but I'd prefer we revisit this to make
common_tests_final_steps work again on webrtc.

[commit-bot: I haz the power, 2016-06-23 07:55:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 07:55:14]

Dry run: Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[kjellander_chromium, 2016-06-23 08:06:51]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 08:06:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086333004/20001

[commit-bot: I haz the power, 2016-06-23 08:10:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 08:10:30]

Dry run: This issue passed the CQ dry run.

[jbudorick, 2016-06-23 08:20:48]

https://codereview.chromium.org/2086333004/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/2086333004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/api.py:1069: "name": "testA",
Guessing the webview stuff comes from this change? I'm not sure how trailing
whitespace even made it in beyond presubmit...

[kjellander_chromium, 2016-06-23 09:49:24]

darn, forgot to commit. Doing it now.

https://codereview.chromium.org/2086333004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/webrtc/api.py (right):

https://codereview.chromium.org/2086333004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/webrtc/api.py:186:
self.m.chromium_android.shutdown_device_monitor()
On 2016/06/23 07:50:25, jbudorick (EMEA til June 30) wrote:
> Fine with this to fix the bots, but I'd prefer we revisit this to make
> common_tests_final_steps work again on webrtc.

OK. I'll be OOO for 5 weeks starting tomorrow, so I'll leave that to you then :)

[kjellander_chromium, 2016-06-23 09:49:30]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2016-06-23 09:49:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2086333004/#ps20001
(title: "Update webview expectations")

[commit-bot: I haz the power, 2016-06-23 09:49:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086333004/20001

[jbudorick, 2016-06-23 09:51:23]

https://codereview.chromium.org/2086333004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/webrtc/api.py (right):

https://codereview.chromium.org/2086333004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/webrtc/api.py:186:
self.m.chromium_android.shutdown_device_monitor()
On 2016/06/23 09:49:24, kjellander_chromium wrote:
> On 2016/06/23 07:50:25, jbudorick (EMEA til June 30) wrote:
> > Fine with this to fix the bots, but I'd prefer we revisit this to make
> > common_tests_final_steps work again on webrtc.
> 
> OK. I'll be OOO for 5 weeks starting tomorrow, so I'll leave that to you then
:)

Hah, works for me. Enjoy your time off!

[commit-bot: I haz the power, 2016-06-23 09:53:19]

Description was changed from

==========
WebRTC: Remove get_version step from WebRTC bots.

WebRTC's Android bots are using the same toolchain as Android
for test execution on Android. Recent changes made the chromium_android
recipe module depend on the chrome/VERSION file in the checkout, which
doesn't exist. Workaround this by providing a way to skip the version
check and apply it to WebRTC's Android testers.

BUG=622606
==========

to

==========
WebRTC: Remove get_version step from WebRTC bots.

WebRTC's Android bots are using the same toolchain as Android
for test execution on Android. Recent changes made the chromium_android
recipe module depend on the chrome/VERSION file in the checkout, which
doesn't exist. Workaround this by providing a way to skip the version
check and apply it to WebRTC's Android testers.

BUG=622606

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/79755916f19d34ea4591...
==========

[commit-bot: I haz the power, 2016-06-23 09:53:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/79755916f19d34ea4591...