scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__failing_test.json - Issue 2086333004: WebRTC: Remove get_version step from WebRTC bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__failing_test.json

Issue 2086333004: WebRTC: Remove get_version step from WebRTC bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Update webview expectations Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/chromium_android/api.py ('K') | « scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__dbg_.json ('k') | scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__forced.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__failing_test.json

diff --git a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__failing_test.json b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__failing_test.json

index 81e65241af3691fc0a31bac3a3cbee72b71403fc..20c792d42b0d5fbe464b7e1257a3beca5c8e4d18 100644

--- a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__failing_test.json

+++ b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__failing_test.json

@@ -737,20 +737,12 @@

{

"cmd": [

- "python",

- "-u",

- "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",

- "[SLAVE_BUILD]/src/chrome/VERSION",

- "/path/to/tmp/"

- ],

- "name": "get version"

- },

- {

- "cmd": [

"[SLAVE_BUILD]/src/build/android/tombstones.py",

"-a",

"-s",

- "-w"

+ "-w",

+ "--adb-path",

+ "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools/adb"

"env": {

"CHROMIUM_OUTPUT_DIR": "[SLAVE_BUILD]/src/out/Release",

@@ -780,7 +772,7 @@

{

"name": "$result",

- "reason": "1 out of 17 aggregated steps failed. Failures: Step('tools_unittests') failed with return_code 1",

+ "reason": "1 out of 20 aggregated steps failed. Failures: Step('tools_unittests') failed with return_code 1",

"status_code": 1

}

]