Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2086293006: Move GrPipelineBuilder out of gms & reduce use of GrPipelineBuilder.h (Closed)

Created:
4 years, 6 months ago by robertphillips
Modified:
4 years, 6 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move GrPipelineBuilder out of gms & reduce use of GrPipelineBuilder.h Just another step in reining in the GrPLB GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2086293006 Committed: https://skia.googlesource.com/skia/+/28a838e532250fcca9673aca6c4616193a5a139d

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -96 lines) Patch
M gm/beziereffects.cpp View 1 3 chunks +9 lines, -12 lines 0 comments Download
M gm/bigrrectaaeffect.cpp View 1 3 chunks +4 lines, -5 lines 0 comments Download
M gm/constcolorprocessor.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M gm/convexpolyeffect.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M gm/dcshader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/rrects.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M gm/texturedomaineffect.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M gm/yuvtorgbeffect.cpp View 3 chunks +8 lines, -9 lines 0 comments Download
M src/gpu/GrClipMaskManager.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/gpu/GrDrawContextPriv.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 2 chunks +1 line, -1 line 0 comments Download
M src/gpu/GrGpu.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M src/gpu/GrGpuCommandBuffer.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrPipeline.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrSWMaskHelper.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/GrTextureParamsAdjuster.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrTextureProvider.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrXferProcessor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 7 chunks +30 lines, -31 lines 0 comments Download
M tests/PrimitiveProcessorTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/gpu/GrTest.cpp View 1 2 1 chunk +11 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
robertphillips
4 years, 6 months ago (2016-06-23 19:28:51 UTC) #4
bsalomon
lgtm
4 years, 6 months ago (2016-06-23 19:40:01 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086293006/20001
4 years, 6 months ago (2016-06-23 19:44:20 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/9273)
4 years, 6 months ago (2016-06-23 19:47:32 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086293006/40001
4 years, 6 months ago (2016-06-23 20:05:00 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 20:36:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086293006/40001
4 years, 6 months ago (2016-06-23 21:05:58 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 21:07:04 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/28a838e532250fcca9673aca6c4616193a5a139d

Powered by Google App Engine
This is Rietveld 408576698