Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2086273002: Subzero[MIPS32]: Make liveness validation errors easier to interpreit (Closed)

Created:
4 years, 6 months ago by mohit.bhakkad
Modified:
4 years, 6 months ago
CC:
native-client-reviews_googlegroups.com, jaydeep.patil, rich.fuhler_imgtec.com, srdjan.obucina_imgtec.com, sagar.thakur
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero[MIPS32]: Make liveness validation errors easier to interpret This patch repeats the same changes for MIPS32, which are done in https://codereview.chromium.org/2080633004 for ARM and X86 archs. R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=6b44fb07b4bc1ce997a4235827c221d3a1b7d643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/IceTargetLoweringMIPS32.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
mohit.bhakkad
4 years, 6 months ago (2016-06-22 09:59:10 UTC) #3
Jim Stichnoth
lgtm
4 years, 6 months ago (2016-06-22 12:47:21 UTC) #5
Jim Stichnoth
4 years, 6 months ago (2016-06-22 12:47:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6b44fb07b4bc1ce997a4235827c221d3a1b7d643 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698