Subzero: Make liveness validation errors easier to interpret.

Subzero: Make liveness validation errors easier to interpret.

A portion of the translation workflow goes like this:

  dump #1
  renumber instructions
  liveness + live range construction
  validateLiveness (exit on failure)
  dump #2

If there are liveness validation errors, instruction numbers are reported with respect to the new instruction numbers, yet the most recent dump output is with respect to the old instruction numbers.  Confusion ensues.

To fix this, we just do dump #2 before validateLiveness.

BUG= none
R=jpp@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=2943d77ca2b3c2380f34b674960f92264c473360

[Jim Stichnoth, 2016-06-21 13:55:08]

Description was changed from

==========
Subzero: Make liveness validation errors easier to interpret.

BUG= none
==========

to

==========
Subzero: Make liveness validation errors easier to interpret.

A portion of the translation workflow goes like this:

  dump #1
  renumber instructions
  liveness + live range construction
  validateLiveness (exit on failure)
  dump #2

If there are liveness validation errors, instruction numbers are reported with
respect to the new instruction numbers, yet the most recent dump output is with
respect to the old instruction numbers.  Confusion ensues.

To fix this, we just do dump #2 before validateLiveness.

BUG= none
==========

[Jim Stichnoth, 2016-06-21 13:55:08]

stichnot@chromium.org changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com, manasijm@google.com

[John, 2016-06-21 17:00:42]

lgtm

[Jim Stichnoth, 2016-06-21 18:22:21]

Description was changed from

==========
Subzero: Make liveness validation errors easier to interpret.

A portion of the translation workflow goes like this:

  dump #1
  renumber instructions
  liveness + live range construction
  validateLiveness (exit on failure)
  dump #2

If there are liveness validation errors, instruction numbers are reported with
respect to the new instruction numbers, yet the most recent dump output is with
respect to the old instruction numbers.  Confusion ensues.

To fix this, we just do dump #2 before validateLiveness.

BUG= none
==========

to

==========
Subzero: Make liveness validation errors easier to interpret.

A portion of the translation workflow goes like this:

  dump #1
  renumber instructions
  liveness + live range construction
  validateLiveness (exit on failure)
  dump #2

If there are liveness validation errors, instruction numbers are reported with
respect to the new instruction numbers, yet the most recent dump output is with
respect to the old instruction numbers.  Confusion ensues.

To fix this, we just do dump #2 before validateLiveness.

BUG= none
R=jpp@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-06-21 18:22:23]

Committed patchset #1 (id:1) manually as
2943d77ca2b3c2380f34b674960f92264c473360 (presubmit successful).