Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/browser/ui/extensions/extension_message_bubble_browsertest.h

Issue 2086193002: [Extensions UI] Fix a crash when clicking on a bubble's learn more (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Views clicking Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/extension_message_bubble_browsertest.h
diff --git a/chrome/browser/ui/extensions/extension_message_bubble_browsertest.h b/chrome/browser/ui/extensions/extension_message_bubble_browsertest.h
index b89c9da17c586f368ec9d435269aabfda5f51d5b..2822a6ba21d10a3cf3a7247165bd2075841b2a2d 100644
--- a/chrome/browser/ui/extensions/extension_message_bubble_browsertest.h
+++ b/chrome/browser/ui/extensions/extension_message_bubble_browsertest.h
@@ -52,6 +52,11 @@ class ExtensionMessageBubbleBrowserTest
// Performs the platform-specific checks.
virtual void CheckBubbleIsNotPresentNative(Browser* browser) = 0;
+ // Clicks on the corresponding button in the bubble.
+ virtual void ClickLearnMoreButton(Browser* browser) = 0;
+ virtual void ClickActionButton(Browser* browser) = 0;
+ virtual void ClickDismissButton(Browser* browser) = 0;
+
// Adds a new extension that uses the chrome_settings_overrides api to
// override a setting specified in |settings_override_value|.
void AddSettingsOverrideExtension(const std::string& settings_override_value);
@@ -105,6 +110,13 @@ class ExtensionMessageBubbleBrowserTest
// warning bubble, behaves properly.
void TestBubbleWithMultipleWindows();
+ // Tests clicking on the corresponding button in the bubble view. The logic
+ // for these is tested more thoroughly in the unit tests, but this ensures
+ // that nothing goes wrong end-to-end.
+ void TestClickingLearnMoreButton();
+ void TestClickingActionButton();
+ void TestClickingDismissButton();
+
private:
std::unique_ptr<extensions::FeatureSwitch::ScopedOverride>
dev_mode_bubble_override_;

Powered by Google App Engine
This is Rietveld 408576698