Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2086183003: V4L2VEA: fix keyframe is not generated on nyan (Closed)

Created:
4 years, 6 months ago by wuchengli
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

V4L2VEA: fix keyframe is not generated on nyan Nyan does not support V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME yet. But it reports success to V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME and keyframe is not generated. Switch the order of two controls and try V4L2_CID_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE first. BUG=chromium:612198 TEST=Run VEA test on nyan and oak. Review-Url: https://codereview.chromium.org/2069923005 Cr-Commit-Position: refs/heads/master@{#400328} (cherry picked from commit 5a83a05e8647c71db1e155dec4c030d5f581e380) Committed: https://chromium.googlesource.com/chromium/src/+/c67053364e031746af29283a5113fae2214abe8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M media/gpu/v4l2_video_encode_accelerator.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wuchengli
4 years, 6 months ago (2016-06-22 02:24:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c67053364e031746af29283a5113fae2214abe8b.

Powered by Google App Engine
This is Rietveld 408576698