Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2069923005:
V4L2VEA: fix keyframe is not generated on nyan (Closed)
|
Created:
4 years, 6 months ago by wuchengli Modified:
4 years, 6 months ago CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionV4L2VEA: fix keyframe is not generated on nyan
Nyan does not support V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME yet.
But it reports success to V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME
and keyframe is not generated. Switch the order of two controls
and try V4L2_CID_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE first.
BUG=chromium:612198
TEST=Run VEA test on nyan and oak.
Committed: https://crrev.com/5a83a05e8647c71db1e155dec4c030d5f581e380
Cr-Commit-Position: refs/heads/master@{#400328}
Patch Set 1 #
Total comments: 2
Patch Set 2 : add TODO #Messages
Total messages: 17 (9 generated)
wuchengli@chromium.org changed reviewers: + henryhsu@chromium.org, posciak@chromium.org
PTAL
Description was changed from ========== V4L2VEA: fix keyframe is not generated on nyan Nyan does not support V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME yet. But it reports success to V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME and keyframe is not generated. Switch the order of two controls and try V4L2_CID_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE first. BUG=chromium:620617 TEST=Run VEA test on nyan and oak. ========== to ========== V4L2VEA: fix keyframe is not generated on nyan Nyan does not support V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME yet. But it reports success to V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME and keyframe is not generated. Switch the order of two controls and try V4L2_CID_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE first. BUG=chromium:620617 BUG=chromium:612198 TEST=Run VEA test on nyan and oak. ==========
Description was changed from ========== V4L2VEA: fix keyframe is not generated on nyan Nyan does not support V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME yet. But it reports success to V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME and keyframe is not generated. Switch the order of two controls and try V4L2_CID_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE first. BUG=chromium:620617 BUG=chromium:612198 TEST=Run VEA test on nyan and oak. ========== to ========== V4L2VEA: fix keyframe is not generated on nyan Nyan does not support V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME yet. But it reports success to V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME and keyframe is not generated. Switch the order of two controls and try V4L2_CID_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE first. BUG=chromium:612198 TEST=Run VEA test on nyan and oak. ==========
lgtm % nit https://codereview.chromium.org/2069923005/diff/1/media/gpu/v4l2_video_encode... File media/gpu/v4l2_video_encode_accelerator.cc (right): https://codereview.chromium.org/2069923005/diff/1/media/gpu/v4l2_video_encode... media/gpu/v4l2_video_encode_accelerator.cc:431: // Nyan still uses the old control and it reports success for unknown Please add a TODO() with a crbug link.
https://codereview.chromium.org/2069923005/diff/1/media/gpu/v4l2_video_encode... File media/gpu/v4l2_video_encode_accelerator.cc (right): https://codereview.chromium.org/2069923005/diff/1/media/gpu/v4l2_video_encode... media/gpu/v4l2_video_encode_accelerator.cc:431: // Nyan still uses the old control and it reports success for unknown On 2016/06/16 07:54:46, Pawel Osciak wrote: > Please add a TODO() with a crbug link. Done.
The CQ bit was checked by wuchengli@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from posciak@chromium.org Link to the patchset: https://codereview.chromium.org/2069923005/#ps20001 (title: "add TODO")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069923005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by wuchengli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069923005/20001
Message was sent while issue was closed.
Description was changed from ========== V4L2VEA: fix keyframe is not generated on nyan Nyan does not support V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME yet. But it reports success to V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME and keyframe is not generated. Switch the order of two controls and try V4L2_CID_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE first. BUG=chromium:612198 TEST=Run VEA test on nyan and oak. ========== to ========== V4L2VEA: fix keyframe is not generated on nyan Nyan does not support V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME yet. But it reports success to V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME and keyframe is not generated. Switch the order of two controls and try V4L2_CID_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE first. BUG=chromium:612198 TEST=Run VEA test on nyan and oak. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== V4L2VEA: fix keyframe is not generated on nyan Nyan does not support V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME yet. But it reports success to V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME and keyframe is not generated. Switch the order of two controls and try V4L2_CID_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE first. BUG=chromium:612198 TEST=Run VEA test on nyan and oak. ========== to ========== V4L2VEA: fix keyframe is not generated on nyan Nyan does not support V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME yet. But it reports success to V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME and keyframe is not generated. Switch the order of two controls and try V4L2_CID_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE first. BUG=chromium:612198 TEST=Run VEA test on nyan and oak. Committed: https://crrev.com/5a83a05e8647c71db1e155dec4c030d5f581e380 Cr-Commit-Position: refs/heads/master@{#400328} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5a83a05e8647c71db1e155dec4c030d5f581e380 Cr-Commit-Position: refs/heads/master@{#400328} |
